[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 5 08:35:55 PST 2016


Anastasia added inline comments.


================
Comment at: test/CodeGenOpenCL/address-spaces-mangling.cl:36
+
+__attribute__((overloadable)) void foo(private char *);
+__attribute__((overloadable)) void foo(global char *);
----------------
Just trying to understand what we are missing in the current testing. Does the additional code test something different from the previous one? Could we reuse the old test but just run it with the other OpenCL versions?

Also do we have any different behavior in the mangler depending on OpenCL versions? 


https://reviews.llvm.org/D27403





More information about the cfe-commits mailing list