[PATCH] D27310: Handle tests for noexcept that expect a false value

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 5 01:34:04 PST 2016


EricWF added a comment.

Please address the inline comments before committing.



================
Comment at: test/libcxx/strings/iterators.exceptions.pass.cpp:29
+#ifndef TEST_HAS_NO_EXCEPTIONS
+constexpr bool expected = false;
+#else
----------------
We can't use constexpr because these tests run in C++03. However `const bool expected = ...` should give you a value you can use in constant expressions.


https://reviews.llvm.org/D27310





More information about the cfe-commits mailing list