[PATCH] D27153: [libc++] Make __num_get_float hidden

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 5 01:17:17 PST 2016


EricWF added a comment.

In https://reviews.llvm.org/D27153#606296, @smeenai wrote:

> I'm having some second thoughts about this. Visibility for template functions makes my head spin :/ Is there a general policy we've been following for these? I didn't find much just scanning through other definitions.


I would suggest adding the `inline` keyword so that implicit instantiation are marked hidden when `-fvisibility-inlines-hidden`. That should be sufficient to hide the implicit instantiations in `libc++.so`.


https://reviews.llvm.org/D27153





More information about the cfe-commits mailing list