[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

Mon Dec 5 00:41:47 PST 2016

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D26934#604325, @smeenai wrote:

> I'd prefer `#error`; that way we can eventually just drop the macro. Ideally there wouldn't be too many users to begin with, since it was only introduced two months ago, and it hasn't made its way to a release yet.

If it hasn't even made it into a release then we probably don't need the `#error` at all. Feel free to commit with or w/o it.

Either way this LGTM.

https://reviews.llvm.org/D26934