[PATCH] D27023: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 23:37:59 PST 2016


EricWF added a comment.

LGTM.

Feel free to address the inline comments or not.



================
Comment at: test/std/containers/sequences/deque/deque.capacity/access.pass.cpp:55
         std::deque<int> c = make<std::deque<int> >(10);
         for (unsigned i = 0; i < 10; ++i)
+            assert(c[i] == static_cast<int>(i));
----------------
Wouldn't it make more sense to change these loop indexes to be `int` instead of `unsigned`?


https://reviews.llvm.org/D27023





More information about the cfe-commits mailing list