[libcxx] r288566 - Revert workaround for Clang bug. Thanks to Richard for the quick fix

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 17:28:02 PST 2016


Author: ericwf
Date: Fri Dec  2 19:28:01 2016
New Revision: 288566

URL: http://llvm.org/viewvc/llvm-project?rev=288566&view=rev
Log:
Revert workaround for Clang bug. Thanks to Richard for the quick fix

Modified:
    libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp

Modified: libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp?rev=288566&r1=288565&r2=288566&view=diff
==============================================================================
--- libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp (original)
+++ libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp Fri Dec  2 19:28:01 2016
@@ -54,11 +54,7 @@ constexpr bool throws_callable() {
 void test_noexcept_function_pointers()
 {
     struct Dummy { void foo() noexcept {} static void bar() noexcept {} };
-
-// FIXME(EricWF): Remove the __clang__ workaround. As of 2/12/2016 Clang has
-// a bug where calling a noexcept function pointer is not noexcept.
-// See https://llvm.org/bugs/show_bug.cgi?id=31244
-#if !defined(__cpp_noexcept_function_type) || defined(__clang__)
+#if !defined(__cpp_noexcept_function_type)
     {
         // Check that PMF's and function pointers *work*. is_nothrow_callable will always
         // return false because 'noexcept' is not part of the function type.




More information about the cfe-commits mailing list