[libcxxabi] r288457 - Update implementation of ABI support for throwing noexcept function pointers

[Richard Smith via cfe-commits]

Looks like we need to wrap more of the test in the feature test macro.

On 2 December 2016 at 13:42, Renato Golin via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> It's been a while, and new patches are coming. Should we just revert
> this for now?
>
> --renato
>
> On 2 December 2016 at 10:13, Renato Golin <renato.golin at linaro.org> wrote:
> > On 2 December 2016 at 02:06, Richard Smith via cfe-commits
> > <cfe-commits at lists.llvm.org> wrote:
> >> Author: rsmith
> >> Date: Thu Dec  1 20:06:53 2016
> >> New Revision: 288457
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=288457&view=rev
> >> Log:
> >> Update implementation of ABI support for throwing noexcept function
> pointers
> >> and catching as non-noexcept to match the final design per discusson on
> >> cxx-abi-dev.
> >
> > Hi Richard,
> >
> > I hope you've seen this:
> >
> > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-
> libunwind-aarch64-linux/builds/4
> >
> > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-
> libunwind-aarch64-linux-noexceptions/builds/6
> >
> > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-
> libunwind-arm-linux/builds/97
> >
> > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux-
> noexceptions/builds/109
> >
> > error: exception specifications are not allowed in type aliases
> > template<bool Noexcept> using FnType = void() noexcept(Noexcept);
> >
> > error: exception specifications are not allowed in type aliases
> > template<bool Noexcept> using FnType = void (X::*)() noexcept(Noexcept);
> >
> > cheers,
> > --renato
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161202/701e908b/attachment.html>