[PATCH] D27300: [OpenCL] Fix SPIR version generation.

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 07:11:11 PST 2016


Anastasia added inline comments.


================
Comment at: test/CodeGenOpenCL/spir_version.cl:22
+
 // CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]}
 // CHECK-SPIR-CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]}
----------------
Could we then use VER here too?


================
Comment at: test/CodeGenOpenCL/spir_version.cl:26
 
 // CHECK-AMDGCN-CL10: !opencl.ocl.version = !{[[OCL:![0-9]+]]}
 // CHECK-AMDGCN-CL10: [[OCL]] = !{i32 1, i32 0}
----------------
Btw, would it make sense to add for AMD targets?
  CHECK-NOT: !opencl.spir.version




https://reviews.llvm.org/D27300





More information about the cfe-commits mailing list