[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons added inline comments.


================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// marked with override or final.
----------------
flx wrote:
> malcolm.parsons wrote:
> > flx wrote:
> > > malcolm.parsons wrote:
> > > > Do we want to warn about methods in templated classes at all?
> > > I think we should still trigger on methods where we can determine that the parameter type is expensive to copy. Note that this is not the case when the type is dependent.
> > We still have issues when the overriding method is not marked override or final.
> > Is there another way to handle this?
> I filed https://llvm.org/bugs/show_bug.cgi?id=31236 to keep track of fixing the check for this case as well.
Thanks.


https://reviews.llvm.org/D27248