[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

Malcolm Parsons via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 01:57:26 PST 2016


On 2 December 2016 at 09:50, Mads Ravn <madsravn at gmail.com> wrote:
>> Comment at: test/clang-tidy/misc-string-compare.cpp:9
>> +  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: do not use compare to test
>> equality of strings; use the string equality operator instead
>> [misc-string-compare]
> What do you mean by this comment?

I was replying to my previous line comment, but the line that was
commented on has changed since.

My comment was:

There's still no test for the single parameter c-string overload.

-- 
Malcolm Parsons


More information about the cfe-commits mailing list