[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

ZiXuan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 1 20:15:45 PST 2016


Zeson added a comment.

In https://reviews.llvm.org/D27251#610629, @kbarton wrote:

> Please make explicit the signed for the parameters to the functions you are changing and remove unnecessary casts. I marked the first few that I found, but stopped marking them after the first several.


I think it does not need to make explicit signed for the parameters such as making `vector int` to `vector signed int`, making `vector short` to `vector signed short`.
The whole file containing lots of such issues can be modified or fixed in another single patch to avoid introducing noise in this patch.


https://reviews.llvm.org/D27251





More information about the cfe-commits mailing list