[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

Kostya Serebryany via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 1 15:22:54 PST 2016


kcc added a comment.

I am not sure this is going to work. 
You essentially break on the first iteration in the beginning of the loop. 
Why not exit the function before the loop? 
Also, the loop "claims" the args and by breaking early you leave the args unclaimed.

I don't remember this code well enough to argue about it w/o tests. :(


https://reviews.llvm.org/D27316





More information about the cfe-commits mailing list