[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 1 13:03:01 PST 2016


ahatanak added a comment.

In https://reviews.llvm.org/D27304#610944, @thegameg wrote:

> In https://reviews.llvm.org/D27304#610697, @joerg wrote:
>
> > I think this is the absolutely wrong place to put such logic. It really can not be anywhere but the backend.
>
>
> I am aware of this. But the way the backend informs the Diagnostics looks like a crash, and asks for a bug report.
>
> Are there any proper ways to inform the frontend about backend errors?


Instead of checking the return type in SemaChecking.cpp, is defining a virtual function in TargetInfo and overriding it in X86TargetInfo an option?


https://reviews.llvm.org/D27304





More information about the cfe-commits mailing list