[PATCH] D27300: [OpenCL] Fix SPIR version generation.

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: test/CodeGenOpenCL/spir_version.cl:21
-// CHECK-SPIR-CL12: [[SPIR]] = !{i32 2, i32 0}
-// CHECK-SPIR-CL12: [[OCL]] = !{i32 1, i32 2}
 // CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]}
----------------
echuraev wrote:
> yaxunl wrote:
> > why this is removed?
> After my changes, value of SPIR version and OCL will be the same and so, it will be generate only one metadata (e.g. !1 = !{i32 1, i32 2}).
> The same situation is for checking CL20 below.
but line 19 still checking with OCL, shouldn't it be changed to the common version metadata shared between SPIR and OCL? How about rename SPIR in line 18 to VER?


https://reviews.llvm.org/D27300