[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

[Nemanja Ivanovic via Phabricator via cfe-commits]

nemanjai added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:8193
+    if (getTarget().isLittleEndian()) {
+      // Create a shuffle mask of (1, 0)
+      Constant *ShuffleElts[2] = { ConstantInt::get(Int32Ty, 1),
----------------
This will likely have to change when the wording is settled on for this builtin. Namely, the element to insert is in BE word element 1 for the instruction. So it is quite likely that the builtin will be made "endianness-neutral" by specifying the source element to be word element 1 (for both LE/BE).


Repository:
  rL LLVM

https://reviews.llvm.org/D26546