[PATCH] D27090: Add LocationContext as a parameter to checkRegionChanges

[Anna Zaks via Phabricator via cfe-commits]

zaks.anna added a comment.

Thank you for doing this!!!

Artem, do you want to disallow the creation of successors from checkRegionChanges callback or can this go in as is?

Anna.



================
Comment at: lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:240
-  /// #checkRegionChanges when no checkers are tracking any state.
-  bool wantsRegionChangeUpdate(ProgramStateRef St) const { return true; }
-
----------------
You should mention that you are deleting this in the commit message or split into a separate commit that could go in before this commit.


================
Comment at: lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:255
   ///
-  /// Note that this callback will not be invoked unless
-  /// #wantsRegionChangeUpdate returns \c true.
+  /// Note: wantsRegionChangeUpdate has recently been removed as
+  ///       it's been unused since checkPointerEscape was added
----------------
Please, remove this comment altogether.


https://reviews.llvm.org/D27090