[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 30 05:43:52 PST 2016


nemanjai added a comment.

Thank you for fixing these issues. I certainly see how the shifts really need to get the signedness right because the right shifts need to fill with the sign bit (so that vector bool will still have all 0 or all 1 bits). However, I don't really follow why the comparisons need to be signed. Could you just elaborate a bit on that?
Other than satisfying my curiosity on that, this LGTM.


https://reviews.llvm.org/D27251





More information about the cfe-commits mailing list