[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 30 03:15:08 PST 2016
arphaman added a comment.
In https://reviews.llvm.org/D26922#608815, @ahatanak wrote:
> Yes, I meant ParseDecl:5266. Reading the comment in ShouldEnterDeclaratorScope, it seemed to me that it shouldn't return true in this context (when parsing an objective-c).
Yes, I agree that it's better to move the check to ShouldEnterDeclaratorScope, I will update the patch.
> Also, the following code (which is not valid) crashes with ToT trunk,
>
> @property (nonatomic) int OuterType::InnerType
>
>
> but compiles without any errors with your patch applied. Do you know why clang doesn't error out?
Repository:
rL LLVM
https://reviews.llvm.org/D26922
More information about the cfe-commits
mailing list