[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons added inline comments.


================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// marked with override or final.
----------------
Do we want to warn about methods in templated classes at all?


================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:284
+template <typename T>
+struct NegativOverrideImpl : public NegativeDependentTypeInterface<T> {
+  void Method(ExpensiveToCopyType E) override {}
----------------
Typo Negativ -> Negative.


Repository:
  rL LLVM

https://reviews.llvm.org/D27248