[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

Joerg Sonnenberger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 07:21:03 PST 2016


joerg added a comment.

Which struct are we talking about, `CompileCommandRef` or `CompileCommand`? It is a pointer in the former and a plain StringRef in the latter. I don't think making it a pointer in both is an advantage, i.e. distinguishing empty input from missing field is not valuable in my opinion.


Repository:
  rL LLVM

https://reviews.llvm.org/D27138





More information about the cfe-commits mailing list