[PATCH] D27208: [change-namespace] fix non-calling function references.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM with few nits.



================
Comment at: change-namespace/ChangeNamespace.cpp:434
+    assert(Func);
+    const Decl *Context = Result.Nodes.getNodeAs<Decl>("dc");
+    assert(Context && "Empty decl context.");
----------------
auto


================
Comment at: change-namespace/ChangeNamespace.cpp:449
       return;
-    const clang::Decl *Context = Result.Nodes.getNodeAs<clang::Decl>("dc");
+    const Decl *Context = Result.Nodes.getNodeAs<Decl>("dc");
     assert(Context && "Empty decl context.");
----------------
auto.


================
Comment at: change-namespace/ChangeNamespace.cpp:713
+    const DeclRefExpr *Ref) {
+    SourceRange RefRange = Ref->getSourceRange();
+    replaceQualifiedSymbolInDeclContext(Result, UseContext, RefRange.getBegin(),
----------------
nits: incorrect indentation. Should be two space.


https://reviews.llvm.org/D27208