[PATCH] D26916: [ObjC] Avoid a @try/@finally/@autoreleasepool fixit when parsing an expression

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 12:59:59 PST 2016


bruno added a comment.

Hi Alex, thanks for working on this



================
Comment at: lib/Parse/ParseObjc.cpp:2877
+        if (GetLookAheadToken(1).is(tok::l_brace) &&
+            ExprStatementTokLoc == AtLoc) {
           char ch = Tok.getIdentifierInfo()->getNameStart()[0];
----------------
Does this only triggers when `Res.isInvalid()` returns true in the first part of the patch? I wonder if it's also safe to allow  `ExprStatementTokLoc = AtLoc;` for every path or only when it fails.


Repository:
  rL LLVM

https://reviews.llvm.org/D26916





More information about the cfe-commits mailing list