[PATCH] D27059: [clang-move] Enable dump all declarations in old header.
Eric Liu via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 24 01:48:26 PST 2016
ioeric added a comment.
LG with a nit.
================
Comment at: clang-move/tool/ClangMoveMain.cpp:155
+ // Don't print trailing "," at the end of last element.
+ if (DeclPair != *(--Declarations.end()))
+ llvm::outs() << ",\n";
----------------
This check is run in each iteration... maybe just loop from `begin()` to `end()-1` and special casing the last element, in which case you don't need to check in each run.
https://reviews.llvm.org/D27059
More information about the cfe-commits
mailing list