[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

Eric van Gyzen via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 09:53:40 PST 2016


vangyzen created this revision.
vangyzen added a subscriber: cfe-commits.
Herald added a subscriber: emaste.

Locale data can vary across platforms.  Rather than hard-code the expected
data in the units tests, get it from the OS via the C API.

This fixes these unit tests on FreeBSD.  It might fix them on Linux, too.
I have not tested other platforms, but I will if I get agreement
on the approach.


https://reviews.llvm.org/D26979

Files:
  test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp
  test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26979.78886.patch
Type: text/x-patch
Size: 4079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161122/adbfa552/attachment.bin>


More information about the cfe-commits mailing list