[PATCH] D26940: [libc++] Remove unneeded visibility pragmas

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 15:01:17 PST 2016


smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.

The function definitions being guarded by the pragma were all static, so
they wouldn't be exported anyway. In any case, we should prefer the
visibility macros. No functional change.


https://reviews.llvm.org/D26940

Files:
  src/chrono.cpp


Index: src/chrono.cpp
===================================================================
--- src/chrono.cpp
+++ src/chrono.cpp
@@ -90,8 +90,6 @@
 // MachInfo.numer / MachInfo.denom is often 1 on the latest equipment.  Specialize
 //   for that case as an optimization.
 
-#pragma GCC visibility push(hidden)
-
 static
 steady_clock::rep
 steady_simplified()
@@ -129,8 +127,6 @@
     return &steady_full;
 }
 
-#pragma GCC visibility pop
-
 steady_clock::time_point
 steady_clock::now() _NOEXCEPT
 {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26940.78792.patch
Type: text/x-patch
Size: 500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161121/02e62c96/attachment.bin>


More information about the cfe-commits mailing list