[PATCH] D26911: readability-redundant-declarations: Fix crash

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 06:32:06 PST 2016


hokein accepted this revision.
hokein added a reviewer: hokein.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:33
     return;
+  if (!Prev->getLocation().isValid())
+    return;
----------------
Maybe put this statement in front of `if (Prev->getLocation() == D->getLocation())`?


Repository:
  rL LLVM

https://reviews.llvm.org/D26911





More information about the cfe-commits mailing list