[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 18 18:03:21 PST 2016


rsmith added a comment.

This should only be needed if you are not using `-fmodules-local-submodule-visibility` and do not have a module map for your C standard library. Is that really a configuration we want to support? Building without `-fmodules-local-submodule-visibility` typically only works if you modularize bottom-up, due to issues exactly like this one.



================
Comment at: include/locale.h:2
+// -*- C++ -*-
+//===---------------------------- math.h ----------------------------------===//
+//
----------------
This is not math.h.


https://reviews.llvm.org/D26826





More information about the cfe-commits mailing list