[PATCH] D26812: [libcxx] [test] In random tests, use real static_asserts and silence a warning.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 18 15:00:38 PST 2016


STL_MSFT accepted this revision.
STL_MSFT added a reviewer: STL_MSFT.
STL_MSFT added a comment.
This revision is now accepted and ready to land.

Made the requested changes, committed as r287391 with Eric's approval.



================
Comment at: test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp:44
+    #pragma warning(push)
+    #pragma warning(disable: 4310) // cast truncates constant value
+#endif // _MSC_VER
----------------
EricWF wrote:
> Warning "4310"? `#pragma GCC warning ignored "-Wwarning-name"` is so much better. Your compiler is bad and you should feel bad. :-P
Yeah, but C4310 is so much more searchable on the internet! :-P


https://reviews.llvm.org/D26812





More information about the cfe-commits mailing list