[PATCH] D26830: [libcxx] Add string_view literals

Anton Bikineev via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 18 03:12:29 PST 2016


AntonBikineev added inline comments.


================
Comment at: include/string_view:749
 
+inline namespace literals
+{
----------------
EricWF wrote:
> If this is new to C++17 then the new declarations should be guarded by `#if _LIBCPP_VERSION > 14`.
Eric, I was thinking about it, but the fact that the whole string_view code is not guarded by _LIBCPP_VERSION > 14 (I guess it's because it can be compiled with lower Standards just fine) stopped me from doing that. I'm still not sure though.


https://reviews.llvm.org/D26830





More information about the cfe-commits mailing list