[PATCH] D26814: [libcxx] [test] Change ifstream constructor tests to handle read-only files.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 17 23:15:26 PST 2016


EricWF added a comment.

I really dislike this change. I'm afraid that these changes allow the tests to silently fail for reasons other than `test.dat` being read only.  For example if `test.dat` ever gets deleted, or if libc++'s remote test-harness fails to copy the input file to the remote host.

I'm not sure how to work around your read-only VCS issue though... Do you have any other ideas?


https://reviews.llvm.org/D26814





More information about the cfe-commits mailing list