[PATCH] D26816: [libcxx] [test] Fix non-Standard assumptions when testing sample().

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 17 23:00:31 PST 2016


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp:74
   assert(end.base() - oa == std::min(os, is));
-  assert(std::equal(oa, oa + os, oa1));
+  LIBCPP_ASSERT(std::equal(oa, oa + os, oa1));
   end = std::sample(PopulationIterator(ia),
----------------
Please add a comment here explaining that the algorithm is non-reproducable.


https://reviews.llvm.org/D26816





More information about the cfe-commits mailing list