EricWF added a comment. Please add tests to `cxx1y-user-defined-literals.cpp` (and probably rename it). Other than that this LGTM, but I don't feel comfortable approving clang patches. https://reviews.llvm.org/D26829