[PATCH] D26830: [libcxx] Add string_view literals

[Eric Fiselier via cfe-commits]

EricWF added a comment.

Which paper is this implementing?

Also please update the synopsis comment at the top of the header.



================
Comment at: include/string_view:749
 
+inline namespace literals
+{
----------------
If this is new to C++17 then the new declarations should be guarded by `#if _LIBCPP_VERSION > 14`.


================
Comment at: include/string_view:754
+    _LIBCPP_CONSTEXPR
+    string_view operator "" sv(const char* __str, size_t __len) _NOEXCEPT
+    {
----------------
Please add `inline _LIBCPP_INLINE_VISIBILITY` to each of these declarations.


https://reviews.llvm.org/D26830