[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 17 18:02:10 PST 2016


smeenai added a comment.

Ping.

I used @EricWF's ABI list verification work to confirm that this diff doesn't change the ABI of libc++ on both Darwin and Linux, so it should be completely safe.

Building with hidden visibility on top of this patch gives the following ABI removals: https://reviews.llvm.org/P7937. I'll be going through this list over the next few days to figure out if the omissions are actually correct or if they're indicative of missing source export annotations. https://reviews.llvm.org/D26823 resulted from this effort.


https://reviews.llvm.org/D25208





More information about the cfe-commits mailing list