[PATCH] D26774: [CUDA] Driver changes to support CUDA compilation on MacOS.
Artem Belevich via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 17 13:31:05 PST 2016
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM, with couple of minor nits.
================
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+ // Intentionally omitted from the switch above: llvm::Triple::CUDA. CUDA
+ // compiles always need two toolchains, the CUDA toolchain and the host
+ // toolchain. So the only valid way to create a CUDA toolchain is via
+ // CreateOffloadingDeviceToolChains.
----------------
should there be an assert() or llvm_unreachable() to ensure that? Right now we'll happily return default toolchain.
================
Comment at: clang/test/Driver/cuda-detect.cu:67
// RUN: -check-prefix LIBDEVICE -check-prefix LIBDEVICE35
+// RUN: %clang -### -v --target=i386-unknown-linux --cuda-gpu-arch=sm_35 \
+// RUN: -nocudainc --cuda-path=%S/Inputs/CUDA/usr/local/cuda %s 2>&1 \
----------------
Should that be --target=i386-apple-macosx ?
https://reviews.llvm.org/D26774
More information about the cfe-commits
mailing list