[PATCH] D22334: Fix for Bug 28172 : clang crashes on invalid code (with too few arguments to __builtin_signbit) without any proper diagnostics.

[David Majnemer via cfe-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: lib/Sema/SemaChecking.cpp:110
+    S.Diag(ValArg->getLocStart(), diag::err_typecheck_cond_expect_float)
+      << ValArg->getType() << ValArg->getSourceRange();
+    return true;
----------------
Can you change this `ValArg->getType()` to `Ty`?


https://reviews.llvm.org/D22334