[PATCH] D26753: ASTImporter: improve support for C++ templates

[Aleksei Sidorin via cfe-commits]

a.sidorin added a comment.

Thank you! I'll update this review again when I have a test for NestedNameSpecifierLocs.



================
Comment at: lib/AST/ASTImporter.cpp:458
+  }
+  return true;
+}
----------------
spyffe wrote:
> Is this really an appropriate default result?  I would argue for `false` here so that an error would propagate, as is typical in ASTImporter.
> Note that this does disagree with the original source's `true` but I think that was because we knew we didn't handle anything, whereas now the assumption is we handle everything.
Good point. Default `false` will also fail import if a new non-handled property or option will be added in AST and clearly indicate an error so I will change it.


https://reviews.llvm.org/D26753