[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

[David Majnemer via cfe-commits]

majnemer added inline comments.


================
Comment at: lib/Sema/SemaTemplate.cpp:7683-7685
+        // or implicit instantiation. MinGW doesn't allow this. In the implicit
+        // instantiation case, we limit clang to only adding dllexport; see the
+        // discussion in https://reviews.llvm.org/D26657 for details.
----------------
Please do not do this. The canonical location for comments in LLVM are the comments themselves.

We have moved the location of the review system and I can easily believe that it will move yet again.


https://reviews.llvm.org/D26657