[PATCH] D26657: [Sema] Respect DLL attributes more faithfully
Shoaib Meenai via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 16 22:15:58 PST 2016
smeenai added inline comments.
================
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+ if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+ Old_TSK == TSK_ImplicitInstantiation) &&
(TSK == TSK_ExplicitInstantiationDefinition ||
DLLImportExplicitInstantiationDef)) {
----------------
rnk wrote:
> Is this the right logic in the case of `Old_TSK == TSK_Implicit && TSK == TSK_Explicit`? We don't want a behavior change when DLLImport is not involved. A test for that case would be good.
I'm actually concerned about the `dllexport` case and not the `dllimport` case, after my discussion with @hans. I'm updating this diff to that effect.
https://reviews.llvm.org/D26657
More information about the cfe-commits
mailing list