[PATCH] D26768: [analyzer] Improve VirtualCallChecker diagnostics and move out of alpha

Devin Coughlin via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 16 14:42:22 PST 2016


dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added subscribers: cfe-commits, alexfh.

The VirtualCallChecker is in alpha because its interprocedural diagnostics represent the call path textually in the diagnostic message rather than with a path sensitive diagnostic.

This patch turns off the AST-based interprocedural analysis in the checker so that no call path is needed and improves with diagnostic text. With these changes, the checker is ready to be evaluated to move out of alpha.

Ultimately the right fix is to rewrite this checker to be path sensitive -- but there is still value in enabling the checker by default for intraprocedural analysis only. The interprocedural mode can be re-enabled with an -analyzer-config flag.


https://reviews.llvm.org/D26768

Files:
  include/clang/StaticAnalyzer/Checkers/Checkers.td
  lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
  test/Analysis/dtor.cpp
  test/Analysis/virtualcall.cpp
  test/Analysis/virtualcall.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26768.78263.patch
Type: text/x-patch
Size: 10915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161116/7dc81131/attachment-0001.bin>


More information about the cfe-commits mailing list