[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 11:25:08 PST 2016


jlebar marked 6 inline comments as done.
jlebar added a comment.

Capturing an IRC conversation:

> **EricWF** jlebar: Did you test this patch with older Clangs w/o constexpr builtins?
>  **jlebar** EricWF, Do you mean, did I test the test, or did I test that the non-test change does what I need?
>  **EricWF** jlebar: I'm wondering if older clangs emit a never-constexpr diagnostic if the builtin isn't > constexpr.
>  **jlebar** EricWF, clang 3.3 and earlier do.
>  **EricWF** OK then we're good :-)

Thank you again for the comments; submitting now with the fixes above.


https://reviews.llvm.org/D25403





More information about the cfe-commits mailing list