[PATCH] D26582: [clang-tidy] Handle template instantiations in modenize-use-default check

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 10:05:51 PST 2016


aaron.ballman added inline comments.


================
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef<T>::~TempODef() = default;
+
----------------
Would it be better if the `= default` were on the inline declaration rather than the out-of-line definition? If so, that might be a reasonable FIXME to add to this test (assuming you don't feel like fixing it as part of this patch).

Also, does the `= delete` check suffer from the same issue?


https://reviews.llvm.org/D26582





More information about the cfe-commits mailing list