[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix
Marshall Clow via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 15 07:17:10 PST 2016
mclow.lists added inline comments.
================
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
----------------
malcolm.parsons wrote:
> This is in `NumericLiteralParser::isValidUDSuffix()`.
>
> If a change is needed for `"sv"`, wouldn't it be in `StringLiteralParser`?
Would it be? I don't know. `"s"` appears here, which is used for both 'string' and 'seconds'.
https://reviews.llvm.org/D26667
More information about the cfe-commits
mailing list