[PATCH] D26588: Add LocationContext to members of check::RegionChanges

[Artem Dergachev via cfe-commits]

NoQ added inline comments.


================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:735
+  const FunctionDecl *FunctionDecl = SFC->getDecl()->getAsFunction();
+  unsigned NumArgs = FunctionDecl->getNumParams();
+  assert(ArgIdx < NumArgs && "Arg access out of range!");
----------------
a.sidorin wrote:
> Maybe we should put a check that requested StackFrame is our StackFrame or our parent StackFrame here?
Hmm. We should probably add a similar check to `getSVal(Ex, LCtx)`!- and also check that `Ex` is an active expression.

Unfortunately, we do not know the current location context within any of these methods, not sure how to implement that.


https://reviews.llvm.org/D26588