[PATCH] D26559: Insert a type check before reading vtable.

[Peter Collingbourne via cfe-commits]

pcc added inline comments.


================
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+  EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+                CallLoc, This, C.getRecordType(DD->getParent()));
----------------
pcc wrote:
> Is it correct to emit a type check at this point? Looking at [0] it looks like this function is only called from the Microsoft C++ ABI after we have already resolved the virtual function pointer.
> 
> [0] http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CGExprCXX.cpp/rEmitCXXDestructorCall
What about this comment?


https://reviews.llvm.org/D26559