[PATCH] D26592: [change-namespace] consider typedef/using alias decls in the moved namespace.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 14 07:36:45 PST 2016


ioeric marked an inline comment as done.
ioeric added inline comments.


================
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:829
                      "void f() {\n"
-                     "  using na::CA;\n"
-                     "  CA ca;\n"
+                     "  using ::na::C_A;\n"
+                     "  C_A ca;\n"
----------------
hokein wrote:
> Any reason to change the existing test case?
This was a typo that I found when manually running unit tests (instead of using `check clang-tools-extra`). In the old code, `using na::CA;` does not compile, so I figure I might just fix here as well.


https://reviews.llvm.org/D26592





More information about the cfe-commits mailing list