[PATCH] D26512: Protect std::ios tests under libcpp-no-exceptions

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 14 01:34:43 PST 2016


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM modulo inline comments. There are a couple of tests which don't explicitly assert if they throw or not. Please address those tests before committing.



================
Comment at: test/std/input.output/iostreams.base/ios/basic.ios.members/set_rdbuf.pass.cpp:44
         ios.exceptions(std::ios::badbit);
     }
     catch (...)
----------------
`assert(false);`

It's unrelated but it should be added.


================
Comment at: test/std/input.output/iostreams.base/ios/iostate.flags/clear.pass.cpp:33
         {
             ios.exceptions(std::ios::badbit);
         }
----------------
`assert(false);`


================
Comment at: test/std/input.output/iostreams.base/ios/iostate.flags/setstate.pass.cpp:33
         {
             ios.exceptions(std::ios::badbit);
         }
----------------
`assert(false)`


https://reviews.llvm.org/D26512





More information about the cfe-commits mailing list