[PATCH] D26415: [XRay] Support AArch64 in Clang

[Serge Rogatch via cfe-commits]

rSerge added inline comments.


================
Comment at: lib/Driver/Tools.cpp:4903-4906
+    if (Triple.getOS() != llvm::Triple::Linux)
+      D.Diag(diag::err_drv_clang_unsupported)
+          << (std::string(XRayInstrumentOption) + " on non-Linux target OS.");
+    switch (Triple.getArch()) {
----------------
rSerge wrote:
> dberris wrote:
> > Did you need to put an `else` before the switch? I don't know what happens when you're on Windows non-supported platform -- will this cause two diagnostics to be printed?
> I thought that the statement after `D.Diag(diag::err_drv_clang_unsupported)` will not be executed. Let me check...
Indeed, it was printing 2 diagnostics. I've added `else`.


https://reviews.llvm.org/D26415