[PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 10 10:27:00 PST 2016


ioeric added inline comments.


================
Comment at: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp:396
+  // Calculate the name of the `NsDecl` after it is moved to new namespace.
+  std::string OldNs = NsDecl->getQualifiedNameAsString();
+  llvm::StringRef Postfix = OldNs;
----------------
mehdi_amini wrote:
> You shouldn't dereference after a `dyn_cast`. Either null-check or use `cast`.
Thanks! Fixed by rL286485


Repository:
  rL LLVM

https://reviews.llvm.org/D24183





More information about the cfe-commits mailing list