[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 10 08:37:01 PST 2016
aaron.ballman added inline comments.
================
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:71
+
+static const StringRef Message = "prefer transparent functors (%0)";
+
----------------
You should quote the %0 to clarify that you're referring to syntax.
================
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:89
+ diag(FuncInst->getLocStart(), Message)
+ << (FuncClass->getName() + "<>").str();
+ return;
----------------
Is the `.str()` required? (Same question applies below.)
https://reviews.llvm.org/D24894
More information about the cfe-commits
mailing list